fix: use unique names for a service's ingresses #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
reviewed
Mar 18, 2019
garden-service/test/unit/src/plugins/kubernetes/container/ingress.ts
Outdated
Show resolved
Hide resolved
thsig
force-pushed
the
fix-multiple-ingresses
branch
from
adac4ad to
328af01
Compare
Before this fix, services defining multiple ingresses would only have the last configured ingress deployed to the cluster (since each ingress for a given service had metadata.name = service.name).
thsig
force-pushed
the
fix-multiple-ingresses
branch
from
328af01 to
b1fbb25
Compare
edvald
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, services defining multiple ingresses would only have the last configured ingress deployed to the cluster (since each ingress for a given service had
metadata.name = service.name).