feat(jib-container): add maven daemon support as project type #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huge thanks for implementing this @ishantagarwal-x213235! 👍 |
vvagaytsev
requested changes
Nov 21, 2022
vvagaytsev
requested changes
Nov 22, 2022
There was a problem hiding this comment.
Thanks for updating this @ishantagarwal-x213235!
I've left a few more comments and suggestions. Please take a look.
vvagaytsev
approved these changes
Nov 23, 2022
|
Looks good! 🚀 Great job, @ishantagarwal-x213235! Thanks for your contribution! |
This was referenced Jan 1, 2024
This was referenced Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added one more build option in
type:jib-containerto use Mavend for faster build processes of maven projects.User can now use
mavendto specify inprojectTypeforjib-containermodules.Eg.
This is useful for maven based projects and aims at providing faster Maven builds, when using jib container module.