feat(k8s): local mode for helm modules #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orzelius
reviewed
Jul 5, 2022
|
Ah I didn't notice it was still WIP, sorry for jumping to the review |
vvagaytsev
force-pushed
the
feat/local-mode-helm-module
branch
18 times, most recently
from
3f2abbe to
ee2468f
Compare
Removing the args will have no effect with `kubectl apply` command which is used by helm module type.
vvagaytsev
force-pushed
the
feat/local-mode-helm-module
branch
from
ee2468f to
5d8929a
Compare
vvagaytsev
force-pushed
the
feat/local-mode-helm-module
branch
from
5d8929a to
eeb0d62
Compare
Orzelius
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
This looks good, but am I correct in that there's currently no integ/e2e test that actually makes a request to the fake proxy service and expects it to be handled locally? I think such test would be also good to have for all three module types to catch the scenario where all the right things are deployed but the proxy itself is not working for whatever reason. This could be a separate pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Local mode for
helmmodules. This is based on the changes made in #2949 and #3003.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
A commit-by-commit review should be an easy way to go.