fix(k8s): error in cleanup-cluster-registry command and added test #1772
Conversation
edvald
force-pushed
the
fix-cleanup
branch
2 times, most recently
from
f73cbf0 to
ce93f01
Compare
.circleci/config.yml
Outdated
| - image: gardendev/garden-gcloud:${CIRCLE_SHA1} | ||
| environment: | ||
| <<: *shared-env-config | ||
| GARDEN_TASK_CONCURRENCY_LIMIT: "10" |
There was a problem hiding this comment.
We don't, it was just in the copy-paste, now removed
.circleci/config.yml
Outdated
| - run: | ||
| name: Cleanup | ||
| command: CIRCLE_BUILD_NUM=$CIRCLE_BUILD_NUM-docker kubectl delete --wait=false $(kubectl get ns -o name | grep testing-$CIRCLE_BUILD_NUM) || true | ||
| when: always | ||
| cleanup-cluster-registry: |
There was a problem hiding this comment.
Will this slow down our e2e tests in a meaningful way? Not the cleanup step itself but rather the next run on a "clean" registry. We of course don't delete images in use, so I'm assuming it won't really have an affect, but wanted to confirm.
There was a problem hiding this comment.
Not by a lot, but there are other issues with running the test like this. I've instead made it a part of the minikube tests, which is in a more closed environment and has no potential of conflicting with another test.
.circleci/config.yml
Outdated
| @@ -374,6 +374,9 @@ jobs: | |||
| name: Deploy demo-project with container | |||
| # overriding CIRCLE_BUILD_NUM to avoid conflict with other tests | |||
| command: CIRCLE_BUILD_NUM=$CIRCLE_BUILD_NUM-docker /garden/garden build --root examples/demo-project --env remote --logger-type basic | |||
| - run: | |||
There was a problem hiding this comment.
Doesn't this run against the CI cluster?
| @@ -4,7 +4,7 @@ name: docker-registry | |||
| type: helm | |||
| chart: stable/docker-registry | |||
| releaseName: garden-docker-registry | |||
| version: 1.8.3 | |||
| version: 1.9.2 | |||
There was a problem hiding this comment.
Is this version already running in our cluster (to make sure the update doesn't break anything)?
|
@edvald, had two outstanding questions :) |
edvald
force-pushed
the
fix-cleanup
branch
2 times, most recently
from
f7dc424 to
4088f98
Compare
edvald
force-pushed
the
fix-cleanup
branch
2 times, most recently
from
b95644c to
77555d3
Compare
|
@eysi09 should be good to go now |
What this PR does / why we need it:
One step of cleaning up the cluster registry was failing, which also prevented following steps to complete. Added a test against our cluster as well, so we should catch these issues from now on.