Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add event and log streaming #1736

Merged
merged 1 commit into from
Apr 14, 2020
Merged

feat(core): add event and log streaming #1736

merged 1 commit into from
Apr 14, 2020

Conversation

thsig
Copy link
Collaborator

@thsig thsig commented Mar 26, 2020

  • Added an event bus to Logger, which emits events when log entries are created or updated.

  • Added the BufferedEventStream class. This is used for batching and streaming events from the Logger and the active Garden instance to the platform when the user is logged in. Later, we can use this class for streaming to the dashboard as well.

@thsig thsig force-pushed the event-streaming branch 2 times, most recently from 258f64c to 17c388e Compare March 30, 2020 09:45
@thsig thsig changed the title WIP: Add client login & event and log streaming. feat(core): add event and log streaming Mar 30, 2020
@thsig thsig marked this pull request as ready for review March 30, 2020 09:47
@thsig thsig force-pushed the event-streaming branch from 17c388e to c7b49ce Compare March 30, 2020 09:49
@thsig thsig force-pushed the event-streaming branch from c7b49ce to a0de25e Compare March 30, 2020 09:54
Copy link
Collaborator

@eysi09 eysi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few comments, otherwise looks good.

garden-service/src/analytics/analytics.ts Outdated Show resolved Hide resolved
garden-service/src/events.ts Show resolved Hide resolved
garden-service/src/logger/log-entry.ts Outdated Show resolved Hide resolved
garden-service/src/platform/buffered-event-stream.ts Outdated Show resolved Hide resolved
garden-service/src/platform/buffered-event-stream.ts Outdated Show resolved Hide resolved
garden-service/src/platform/buffered-event-stream.ts Outdated Show resolved Hide resolved
garden-service/src/platform/buffered-event-stream.ts Outdated Show resolved Hide resolved
garden-service/src/platform/buffered-event-stream.ts Outdated Show resolved Hide resolved
garden-service/src/platform/buffered-event-stream.ts Outdated Show resolved Hide resolved
garden-service/src/logger/log-entry.ts Outdated Show resolved Hide resolved
@thsig thsig force-pushed the event-streaming branch 3 times, most recently from e89334f to fa6f606 Compare April 9, 2020 11:46
Copy link
Collaborator

@eysi09 eysi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@thsig
Copy link
Collaborator Author

thsig commented Apr 14, 2020

Let's not merge this one quite yet, I'm still making a few tweaks.

@thsig thsig force-pushed the event-streaming branch 2 times, most recently from 94c5861 to 1e7af54 Compare April 14, 2020 10:09
* Added an event bus to Logger, which emits events when log entries are
created or updated.

* Added the `BufferedEventStream` class. This is used for batching and
streaming events from the Logger and the active Garden instance to the
platform when the user is logged in. Later, we can use this class for
streaming to the dashboard as well.
@thsig thsig force-pushed the event-streaming branch from 1e7af54 to c2bb392 Compare April 14, 2020 10:35
@thsig thsig merged commit ffc1094 into master Apr 14, 2020
@thsig thsig deleted the event-streaming branch April 14, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants