Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): add build dependencies example #1705

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Conversation

eysi09
Copy link
Collaborator

@eysi09 eysi09 commented Mar 18, 2020

What this PR does / why we need it:

Adds a dedicated "build dependencies" example. This gets asked about a lot in our community channel and so far this pattern has only been used implicitly in other example without proper explanation.

It'll also be referenced from the FAQ doc we're working on.

Which issue(s) this PR fixes:

None.

Special notes for your reviewer:

None.

@eysi09 eysi09 requested a review from thsig March 18, 2020 08:53
Copy link
Collaborator

@thsig thsig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, glad we now have an example demonstrating this pattern! Had a couple of line edit suggestions.

examples/build-dependencies/README.md Outdated Show resolved Hide resolved
examples/build-dependencies/README.md Outdated Show resolved Hide resolved
@thsig thsig self-requested a review March 18, 2020 09:43
Copy link
Collaborator

@thsig thsig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, glad we now have an example demonstrating this pattern! Had a couple of line edit suggestions.

@eysi09 eysi09 force-pushed the build-deps-example branch from 39c271d to ba04ce1 Compare March 18, 2020 09:50
@eysi09 eysi09 merged commit 600e6ac into master Mar 18, 2020
@eysi09 eysi09 deleted the build-deps-example branch March 18, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants