Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): only set config names once in resolveModuleConfigs #1239

Merged
merged 2 commits into from
Oct 2, 2019
Merged

refactor(core): only set config names once in resolveModuleConfigs #1239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baabb98
refactor(core): only set config names once in resolveModuleConfigs
eysi09 Sep 28, 2019
01b336c
Merge branch 'master' into fix-config-names
eysi09 Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions garden-service/src/garden.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,21 +637,6 @@ export class Garden {
const ctx = await this.getPluginContext(provider)
config = await configureHandler({ ctx, moduleConfig: config, log: this.log })

if (config.plugin) {
// Make sure nested entities in plugin modules are scoped by name
for (const serviceConfig of config.serviceConfigs) {
serviceConfig.name = `${config.plugin}--${serviceConfig.name}`
}

for (const taskConfig of config.taskConfigs) {
taskConfig.name = `${config.plugin}--${taskConfig.name}`
}

for (const testConfig of config.testConfigs) {
testConfig.name = `${config.plugin}--${testConfig.name}`
}
}

// FIXME: We should be able to avoid this
config.name = getModuleKey(config.name, config.plugin)

Expand Down