fix(kubernetes-module): handle namespace attribute correctly #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
requested changes
Sep 18, 2019
| } | ||
|
|
||
| function getSelector(service: KubernetesService) { | ||
| return `${gardenAnnotationKey("service")}=${service.name}` | ||
| } | ||
|
|
||
| async function getManifests(module: KubernetesModule): Promise<KubernetesResource[]> { | ||
| async function readManifests(module: KubernetesModule) { |
There was a problem hiding this comment.
Could you add a comment above this function and the getManifests function below so the difference is clear.
Previously we set the --namespace flag when applying the specified resources. We now instead ensure the namespace property is set on every relevant resource. Fixes #1191
edvald
force-pushed
the
fix-namespace-handling
branch
from
0af1cfb to
b6fffd0
Compare
eysi09
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously we set the --namespace flag when applying the specified
resources. We now instead ensure the namespace property is set on every
relevant resource.
Also improved the log output when exec-ing external commands.
Which issue(s) this PR fixes:
Fixes #1191