Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vcs): fixed support for GitHub SSH URLs and added tests #1005

Merged
merged 2 commits into from
Jul 23, 2019
Merged

fix(vcs): fixed support for GitHub SSH URLs and added tests #1005

merged 2 commits into from
Jul 23, 2019

Conversation

edvald
Copy link
Collaborator

@edvald edvald commented Jul 22, 2019

No description provided.

@edvald edvald requested a review from eysi09 July 22, 2019 16:15
@edvald edvald force-pushed the fix-git-url-validation branch from 5606127 to 7b061ec Compare July 22, 2019 16:44
eysi09
eysi09 approved these changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@eysi09 eysi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And thanks for adding the tests!

@eysi09 eysi09 merged commit c43490c into master Jul 23, 2019
@edvald edvald deleted the fix-git-url-validation branch July 31, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eysi09 eysi09 eysi09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edvald @eysi09