Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garden syncs ignored files/dirs to .garden/build dir #968

Closed
eysi09 opened this issue Jul 15, 2019 · 1 comment · Fixed by #970
Closed

Garden syncs ignored files/dirs to .garden/build dir #968

eysi09 opened this issue Jul 15, 2019 · 1 comment · Fixed by #970
Assignees
@edvald
Labels
bug priority:medium Medium priority issue or feature
Milestone
0.10.1

Comments

@eysi09
Copy link
Collaborator

eysi09 commented Jul 15, 2019

Bug

Current Behavior

Garden syncs everything to the ./garden/build dir. Even if some of the content is ignored via the include directive or in a .gardenignore file.

Expected behavior

It should exclude content that's ignored via .gardenignore or missing from the include list if provided.

Reproducible example

  1. Pick and example project
  2. Run rm -rf .garden/build from the root.
  3. Exclude files/dirs by adding a .gardenignore to a module or by using the include directive.
  4. Run a command that stages a build.
  5. Notice that nothing got excluded.

Workaround

N/A.
@eysi09 eysi09 added the priority:medium Medium priority issue or feature label Jul 15, 2019
@eysi09 eysi09 added the bug label Jul 15, 2019
@eysi09
Copy link
Collaborator Author

eysi09 commented Jul 15, 2019

See also #952.

@eysi09 eysi09 mentioned this issue Jul 15, 2019
Closed
@eysi09 eysi09 added this to the 0.10.1 milestone Jul 15, 2019
edvald added a commit that referenced this issue Jul 15, 2019
@edvald
fix(core): respect includes/excludes when syncing to build directory
b6173aa 
This notably cascades neatly to anything that syncs _from_ the build
directory, so there should be no further action needed in e.g.
hot-reloading or remote-building code.

Fixes #968
@edvald edvald mentioned this issue Jul 15, 2019
Merged
edvald added a commit that referenced this issue Jul 16, 2019
@edvald
fix(core): respect includes/excludes when syncing to build directory
3380cbd 
This notably cascades neatly to anything that syncs _from_ the build
directory, so there should be no further action needed in e.g.
hot-reloading or remote-building code.

Fixes #968
edvald added a commit that referenced this issue Jul 16, 2019
@edvald
fix(core): respect includes/excludes when syncing to build directory
5b0b7b6 
This notably cascades neatly to anything that syncs _from_ the build
directory, so there should be no further action needed in e.g.
hot-reloading or remote-building code.

Fixes #968
edvald added a commit that referenced this issue Jul 16, 2019
@edvald
fix(core): respect includes/excludes when syncing to build directory
becfcd3 
This notably cascades neatly to anything that syncs _from_ the build
directory, so there should be no further action needed in e.g.
hot-reloading or remote-building code.

Fixes #968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edvald edvald

Labels
bug priority:medium Medium priority issue or feature
Projects
None yet
Milestone
0.10.1
Development

Successfully merging a pull request may close this issue.

fix(core): respect includes/excludes when syncing to build directory garden-io/garden
2 participants
@edvald @eysi09