Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when docker isn't installed on client #768

Closed
edvald opened this issue May 13, 2019 · 0 comments · Fixed by #793
Closed

Crash when docker isn't installed on client #768

edvald opened this issue May 13, 2019 · 0 comments · Fixed by #793
Assignees

Comments

@edvald
Copy link
Collaborator

edvald commented May 13, 2019

Bug

Current Behavior

When running garden deploy for a local environment with the docker CLI installed, garden crashes:

 garden-example-vote-helm (garden-example-vote-helm→pin-redis-version) garden deploy
Deploy 🚀

⠸ providers                 → Preparing environment...
    ⠹ local-kubernetes          → Configuring...
       ⠹ kubernetes-dashboard      → Building version v-ea099d73da...
       ⠋ ingress-controller        → Building version v-f78df59ea8...
       ⠇ default-backend           → Getting build status...

events.js:167
      throw er; // Unhandled 'error' event
      ^

Error: spawn docker ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:232:19)
    at onErrorNT (internal/child_process.js:407:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)
Emitted 'error' event at:
    at Process.ChildProcess._handle.onexit (internal/child_process.js:238:12)
    at onErrorNT (internal/child_process.js:407:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)

Expected behavior

First off, exceptions of this nature should not crash like this, but rather fail the surrounding task and not crash the process.
Second, it should give a clear error telling the user that docker needs to be installed. Or we could install the docker client automatically, same way we do kubectl, helm etc.

Reproducible example

Make sure docker is not on your PATH. In the garden-example-vote-helm, run garden deploy.

Workaround

Install docker :P

Your environment

Latest garden master. No kubectl or docker installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants