Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename project.globals key to project.defaults #131

Closed
edvald opened this issue May 30, 2018 · 0 comments
Closed

Rename project.globals key to project.defaults #131

edvald opened this issue May 30, 2018 · 0 comments
Assignees
@edvald
Labels
api-change enhancement

Comments

@edvald
Copy link
Collaborator

edvald commented May 30, 2018

Or even environmentDefaults? That would be more verbose but quite clear. Either way I think globals isn't super clear. We talked about it at the time, but I didn't follow up on it. What do you all think makes sense?
edvald added a commit that referenced this issue Jun 7, 2018
@edvald
refactor: rename project.global to project.environmentDefaults (#131)
548ffd2 
BREAKING CHANGE:
Existing garden.yml files will need to be updated if they use the
project.global key.
@edvald edvald mentioned this issue Jun 7, 2018
Merged
@edvald edvald self-assigned this Jun 7, 2018
eysi09 pushed a commit that referenced this issue Jun 8, 2018
@edvald @eysi09
refactor: rename project.global to project.environmentDefaults (#131)
3ebe1dc 
BREAKING CHANGE:
Existing garden.yml files will need to be updated if they use the
project.global key.
eysi09 added a commit that referenced this issue Jun 8, 2018
@eysi09
Merge pull request #159 from garden-io/environment-defaults
078d1a8 
refactor: rename project.global to project.environmentDefaults (#131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edvald edvald

Labels
api-change enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edvald