Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unrecognized resource type batch/v1beta1/CronJob #1275

Closed
garoose opened this issue Oct 21, 2019 · 1 comment · Fixed by #1294
Closed

Unrecognized resource type batch/v1beta1/CronJob #1275

garoose opened this issue Oct 21, 2019 · 1 comment · Fixed by #1294
Assignees
@edvald
Labels
bug

Comments

@garoose
Copy link

garoose commented Oct 21, 2019

Garden doesn't support batch/v1beta1/CronJob API

Current Behavior

Attempting to deploy a Helm chart for a CronJob resource fails with
Unrecognized resource type batch/v1beta1/CronJob

Expected behavior

The resource deploys successfully, as it does with helm upgrade --install

Reproducible example

See https://github.com/garoose/garden-cron-job-test for a small example of the problem

Your environment

garden version
0.10.13

kubectl version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2", GitCommit:"c97fe5036ef3df2967d086711e6c0c405941e14b", GitTreeState:"clean", BuildDate:"2019-10-17T17:16:09Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.4", GitCommit:"67d2fcf276fcd9cf743ad4be9a9ef5828adc082f", GitTreeState:"clean", BuildDate:"2019-09-18T14:41:55Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

docker version
Client:
Version: 18.09.7
API version: 1.38 (downgraded from 1.39)
Go version: go1.10.1
Git commit: 2d0083d
Built: Fri Aug 16 14:20:06 2019
OS/Arch: linux/amd64
Experimental: false

Server:
Engine:
Version: 18.06.1-ce
API version: 1.38 (minimum version 1.12)
Go version: go1.10.4
Git commit: e68fc7a
Built: Tue May 7 17:57:34 2019
OS/Arch: linux/amd64
Experimental: false
@eysi09 eysi09 self-assigned this Oct 22, 2019
@eysi09
Copy link
Collaborator

eysi09 commented Oct 22, 2019

Hi @garoose!

Thanks for reporting this and for the repro example! This should be a quick fix.

@eysi09 eysi09 added the bug label Oct 22, 2019
@eysi09 eysi09 assigned edvald and unassigned eysi09 Oct 25, 2019
edvald added a commit that referenced this issue Oct 30, 2019
@edvald
fix(k8s): handle CronJob resources correctly
68e33dc 
This would also have applied in cases where a group had different
resource types under different API versions. Which is not particularly
common, but most likely affected some other resource types.

Fixes #1275
@edvald edvald mentioned this issue Oct 30, 2019
Merged
edvald added a commit that referenced this issue Oct 31, 2019
@edvald
fix(k8s): handle CronJob resources correctly
e7a4646 
This would also have applied in cases where a group had different
resource types under different API versions. Which is not particularly
common, but most likely affected some other resource types.

This also slightly reduces the number of API calls needed on init.

Fixes #1275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edvald edvald

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(k8s): handle CronJob resources correctly garden-io/garden
3 participants
@edvald @garoose @eysi09