Sign problem 1.20.1 #765
Comments
|
Ok so issue is still there, it worked one time but now again doesn't. When i right click sign it will open edit sign gui and console will say player xxx tried to edit non editable sign. |
|
Is your arena protected by any other plugins, like WorldGuard or GriefPrevention? That seems to be a CraftBukkit message for the cases of the sign being waxed or the wrong player is editing it (don't really understand all this): I have a branch that stops the dialog from being opened, but it may not be the perfect solution: |
|
yup i have wg region |
|
do i need to remove region? |
|
Haven't really looked, but is this possibly due to the new 1.20 feature of double-sided signs? |
garbagemule
added
the
area/misc
|
I only get this on the second arena. The first one works fine. |
Since Minecraft 1.20, players can edit signs by right-clicking on them, and that poses a problem for the sign-centric portions of the plugin, such as class selection signs and the various types of arena signs. This commit refactors the PlayerInteractEvent handler in ArenaListener in order to break open the possibility of handling non-lobby players as well. We're a little more strict with lobby players, and we still want to handle class sign clicks and iron block clicks here. For players who aren't in the lobby, we're really just blocking the event according to the regular protection rules (block is inside region, protect is on, and arena is not in edit mode). It also blanket cancels events in the HandlesSignClicks event handler, because there is no meaningful way to edit an arena sign, since their contents come from the template file and not from what is written on them by the sign renderer. Ideally, we'd refactor some of this event handler logic, because it's a lot easier to take care of the individual responsibilities in separate event handlers. Fixes #765
|
@DexterSK @BobbyTowers @veteranmina I've got a fix for this issue ready if anyone wants to try it out. Let me know if you prefer to build it yourself (branch |
|
I would like a build, what's your discord? |
|
I'll drop one in the #test-builds channel on the MobArena Discord. |
Bug report
Short description
When you right click on arena sign it will open SignGUI
Reproduction steps
Details
Additional info
The text was updated successfully, but these errors were encountered: