Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates remark-toc, remark-gfm, and rehype-autolink-headings libraries #1244

Merged
merged 5 commits into from
Jan 26, 2022

Conversation

SahilKalra98
Copy link
Collaborator

@SahilKalra98 SahilKalra98 commented Dec 29, 2021

This PR updates the following three PRs:
1.#1208
2.#1236
3.#1246

The reason it updates all three is because all three were failing the same tests. Since all the packages were major version updates, they went from CommonJS modules to fully ESM modules. Our jest configuration doesn't support ESM modules yet so I mocked the three modules as a workaround.

@vercel
Copy link

vercel bot commented Dec 29, 2021

@SahilKalra98 is attempting to deploy a commit to a Personal Account owned by @garageScript on Vercel.

@garageScript first needs to authorize it.

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #1244 (ddfe3cc) into master (8cd6ca1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1244   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          146       146           
  Lines         2454      2451    -3     
  Branches       638       638           
=========================================
- Hits          2454      2451    -3     
Impacted Files Coverage Δ
helpers/static/parseMDX.ts 100.00% <ø> (ø)

@vercel
Copy link

vercel bot commented Dec 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/c0d3/c0d3-app/3LVAdMKMvQi165MJ6tHpuh4XA1gU
✅ Preview: https://c0d3-app-git-fork-sahilkalra98-fixremarktoc-c0d3.vercel.app

package.json Outdated
@@ -6,7 +6,7 @@
"scripts": {
"db:init": "prisma migrate reset",
"db:seed": "prisma db seed --preview-feature",
"db:up": "docker-compose --file docker/docker-compose.yml up --detach postgres",
"db:up": "sudo docker-compose --file docker/docker-compose.yml up --detach postgres",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its only sudo for your machine I think, on macOS and windows it should not be sudo. So I don't think the change is good

@songz songz mentioned this pull request Dec 31, 2021
@songz
Copy link
Contributor

songz commented Dec 31, 2021

#1247

@SahilKalra98
Copy link
Collaborator Author

Closing PR because Next.js does not support esm

@flacial
Copy link
Member

flacial commented Jan 22, 2022

NextJS has been updated to v12, it can be merged.

@flacial flacial reopened this Jan 22, 2022
@flacial
Copy link
Member

flacial commented Jan 22, 2022

@SahilKalra98 I reopened this.

@flacial flacial merged commit 84001ce into garageScript:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants