Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -K option to restrict the amount of memory used in tests #959

Merged

Conversation

olexandr-konovalov
Copy link
Member

At the moment, the default value of -K option, which limits the amount of memory available to GAP, is zero. This means that it is limited only by the operating system (more precisely, whether the build is 32 or 64-bit).

Dealing with #896, I observed that this has the following effect on regression tests. The tests are started with -o 1g option, which specifies when to trigger the break loop with Error, reached the pre-set memory limit (change it with the -o command line option) message. When GAP continues to the next command, the workspace grows, and in a case of a test where this may happen several times, this becomes a problem which we observe on our Jenkins slaves (for example, running 4 tests concurrently on a slave with 12 GB RAM).

This pull requests will make use of -K 2g option in all tests invoked via make test<something>. This will be enough to not to interrupt the test completely when the limit of 1g is hit, but will prevent test workspaces from growing to giant sizes.

@codecov-io
Copy link

Current coverage is 49.39% (diff: 100%)

Merging #959 into master will increase coverage by <.01%

@@             master       #959   diff @@
==========================================
  Files           424        424          
  Lines        222804     222804          
  Methods        3430       3430          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits         110040     110055    +15   
+ Misses       112764     112749    -15   
  Partials          0          0          

Powered by Codecov. Last update 79b83e1...b2bf8b2

@olexandr-konovalov olexandr-konovalov merged commit 9afb0fe into gap-system:master Nov 25, 2016
@olexandr-konovalov
Copy link
Member Author

This has the desired effect and calms down our Jenkins slaves

testing: /home/hudson/hudson/workspace/GAP-dev/GAPCOPTS/64build/GAPGMP/gmp/GAP\
TARGET/standard/label/graupius/GAP-git-snapshot/tst/teststandard/grpauto.tst
gap: will not extend workspace above -K limit, bye!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: tests issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants