Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made LARGEST_IDENTIFIER_NUMBER a fixed atomic list. #94

Conversation

olexandr-konovalov
Copy link
Member

This fixes ctblmono.tst run in the background thread.

This fixed ctblmono.tst run in the background thread.
@olexandr-konovalov olexandr-konovalov added topic: HPC-GAP Issues and PRs related to HPC-GAP gapdays2015-spring Issues and PRs that arose at https://www.gapdays.de/gapdays2015-spring labels Mar 19, 2015
@ChrisJefferson
Copy link
Contributor

Looks correct to me (at least thread safe, didn't check if variable is being used anywhere else)

olexandr-konovalov pushed a commit that referenced this pull request Mar 19, 2015
Made LARGEST_IDENTIFIER_NUMBER a fixed atomic list.
@olexandr-konovalov olexandr-konovalov merged commit 2b30855 into gap-system:hpcgap-default Mar 19, 2015
@olexandr-konovalov
Copy link
Member Author

@ChrisJefferson - thanks, perhaps I should make more informative description while submitting this PR. This fix now ensures that ctblmono.tst run in the background thread, and that was the last of the tests needed to run the whole Read("tst/testinstall.g"); in the background thread with zero diffs. I've checked that this this the only place where it's used in the GAP library, and it's not used in any of current packages. Travis tests passed, PR merged.

@olexandr-konovalov olexandr-konovalov deleted the ctblmono-tst-fix branch March 19, 2015 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gapdays2015-spring Issues and PRs that arose at https://www.gapdays.de/gapdays2015-spring topic: HPC-GAP Issues and PRs related to HPC-GAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants