Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ListX, SetX, SumX and ProductX support lists #903

Merged
merged 1 commit into from
Sep 28, 2016

Conversation

ChrisJefferson
Copy link
Contributor

Please make sure that this pull request:

  • [X ] is submitted to the correct branch (the stable branch is only for bugfixes)
  • [X ] contains an accurate description of changes for the release notes below
  • [X ] provides new tests or relies on existing ones
  • [ X] correctly refers to other issues and related pull requests

Tick all what applies to this pull request

  • [X ] Improves and extends functionality

Write below the description of changes (for the release notes)

Extend ListX, SetX, SumX and ProductX to support arbitrary lists, as well as collections.

@codecov-io
Copy link

codecov-io commented Sep 26, 2016

Current coverage is 49.30% (diff: 100%)

Merging #903 into master will increase coverage by 0.11%

@@             master       #903   diff @@
==========================================
  Files           423        423          
  Lines        229156     229156          
  Methods        3448       3448          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits         112717     112980   +263   
+ Misses       116439     116176   -263   
  Partials          0          0          

Powered by Codecov. Last update d60d5c3...78a291e

@ChrisJefferson
Copy link
Contributor Author

Now updated with complete test coverage

@fingolfin
Copy link
Member

This looks sensible to me. And I just had a look at the documentation for ListX, and it actually explicitly states that it expects "a list or collection". So I am confident this it the right things to do!

@fingolfin fingolfin merged commit b6874cf into gap-system:master Sep 28, 2016
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone Sep 28, 2016
@ChrisJefferson ChrisJefferson deleted the listx branch January 25, 2017 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants