Performance improvement and fix of generators #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix assertion typo
not stored generators of the subgroup. This fixes gap-system#887
This was referenced Aug 19, 2016
Current coverage is 49.32% (diff: 70.00%)@@ master #892 diff @@
==========================================
Files 422 422
Lines 228398 228403 +5
Methods 3448 3448
Messages 0 0
Branches 0 0
==========================================
- Hits 112663 112649 -14
- Misses 115735 115754 +19
Partials 0 0
|
Added missing `return` on line 16,, p.163 of Holt's handbook. The forever loop in ScanAndFill is interrupted if a collapse makes i>j. This fixes gap-system#887
|
Note that the travis test failure seems to be in packing a package -- not an issue for the PR. |
|
The travis failure seems to have been some intermittent problem with travis' infrastructure. I re-ran the test and it went through normally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #887