Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IsKernelFunction #876

Merged
merged 2 commits into from
Aug 4, 2016
Merged

Conversation

markuspf
Copy link
Member

@markuspf markuspf commented Aug 4, 2016

Previously this returned False for certain functions installed as kernel functions, and then crashed.

While we're here, also use FuncIsKernelFunction for printing.
@codecov-io
Copy link

codecov-io commented Aug 4, 2016

Current coverage is 48.97% (diff: 100%)

Merging #876 into master will increase coverage by <.01%

@@             master       #876   diff @@
==========================================
  Files           422        422          
  Lines        233840     233840          
  Methods        3481       3481          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits         114515     114532    +17   
+ Misses       119325     119308    -17   
  Partials          0          0          

Powered by Codecov. Last update 072c7b3...0a636f8

@ChrisJefferson
Copy link
Contributor

This is the correct fix for this problem.

Going to be picky, and ask for a couple more tests (mainly, a couple of non-functions, an int and a record perhaps? as those are the things that were causing crashes?)

@markuspf
Copy link
Member Author

markuspf commented Aug 4, 2016

Actually what was causing the segfault was METHODS_OPERATION(\=,2)[34] in my GAP session (equality test for 32bit associative words).

What is slightly misleading is that

gap> IsKernelFunction(Size);
true

Sure, operations are callable, so I'd gather this constitutes IsFunction. Whether it constitutes IsKernelFunction is another question though...

@markuspf
Copy link
Member Author

markuspf commented Aug 4, 2016

Oh, and I added tests for an integer and a record.

@fingolfin fingolfin merged commit 7502761 into gap-system:master Aug 4, 2016
@markuspf markuspf deleted the fix-is-kernel-function branch February 5, 2017 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants