Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intersection #854

Merged
merged 2 commits into from
Jul 8, 2016
Merged

Conversation

markuspf
Copy link
Member

@markuspf markuspf commented Jul 7, 2016

Please make sure that this pull request:

  • is submitted to the correct branch (the stable branch is only for bugfixes)
  • contains an accurate description of changes for the release notes below
  • provides new tests or relies on existing ones
  • correctly refers to other issues and related pull requests

Description of changes (for the release notes)

Fix a bug in Intersection if the parameter given is the empty list.

@markuspf markuspf force-pushed the fix-intersection branch 2 times, most recently from db2cd87 to a1297c1 Compare July 7, 2016 12:26
@codecov-io
Copy link

Current coverage is 49.16%

Merging #854 into master will decrease coverage by <.01%

@@             master       #854   diff @@
==========================================
  Files           422        422          
  Lines        233097     233100     +3   
  Methods        3479       3479          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits         114599     114596     -3   
- Misses       118498     118504     +6   
  Partials          0          0          

Powered by Codecov. Last updated by 6e8b016...903a3a5

@ChrisJefferson
Copy link
Contributor

Looks good to me.
Not sure why we are seeing the amount of coverage bounce around so much. Some random number weirdness I think.

@ChrisJefferson
Copy link
Contributor

Will merge this, as it seems fine.

I notice this matches Union, where Union([]) already works (and produces the same answer).

@ChrisJefferson ChrisJefferson merged commit dfa4a07 into gap-system:master Jul 8, 2016
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone Aug 4, 2016
@markuspf markuspf deleted the fix-intersection branch February 5, 2017 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants