Fix kernel method for 'Remove' with one argument #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following problem (reported to the support list): gap> L:=[1,2,,,3]; [ 1, 2,,, 3 ] gap> Remove(L); 3 gap> L; [ 1, 2,, ] that is, the length was not reduced to the position of the last bound entry.
|
This looks good. Perhaps add a test for the list becoming empty, just to make sure it's right (I'm sure it is, but doesn't hurt to check!) |
|
Of course, I had done some more tests before. I have now added a few more lines to bugfix.tst. |
|
Thanks for fixing this! |
|
@frankluebeck @markuspf Thanks! I think this also should be cherry-picked onto stable-4.8. |
|
I just cherry-picked it, but the merge back into master duplicated the commits. ugly. |
|
Thanks - then changing milestone to 4.8.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following problem (reported to the support list):
gap> L:=[1,2,,,3];
[ 1, 2,,, 3 ]
gap> Remove(L);
3
gap> L;
[ 1, 2,, ]
that is, the length was not reduced to the position of the last bound entry.