Improve transformations code and tests - part 2 #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version was mixing wallclock time and system/user which is probably bad. The new version just uses NanosecondsSinceEpoch to determine the time passed. Also move the timeout test back to testinstall.
The corresponding tests are updated too.
The functions Transformation and TransformationListList now return an error instead of fail if their arguments are not correct. The manual is updated to reflect this.
This should have been done as part of the change to the methods for view strings for semigroups, but it wasn't caught because it is a <Log> and not an <Example>.
|
@james-d-mitchell thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues in PR #727 pointed out by @alex-konovalov. In addition, some manual entries are revised, and some minor further improvements are made in the doc.