Fix OnTuples([-1], (1,2)) returning [-1], as reported in #717 #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuspf
force-pushed
the
fix-on-tuples-perm
branch
from
70cf917
to
3f46b26
Compare
|
Fair enough, though I see little point in returning values from break loops. |
`OnTuplesPerm` left negative integers invariant instead of giving an error, which would be consistent with the manual.
markuspf
force-pushed
the
fix-on-tuples-perm
branch
from
3f46b26
to
558874c
Compare
olexandr-konovalov
changed the title
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnTuplesPermleft negative integers invariant instead of giving anerror, which would be consistent with the manual.