Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PQuotient error for large groups. #5816

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix PQuotient error for large groups. #5816

wants to merge 2 commits into from

Commits on Oct 15, 2024

  1. Fix PQuotient error for large groups. 

    - Return fail in AbelianPQuotient if not enough generators for current
parameters (logord in PQuotient, or #gens in collector of QuotientSystem
qs)
- Return fail or error in PQuotient for large groups, depending on option
noninteractive
- Update documentation of PQuotient
- Add test for bugfix
    @FriedrichRober
    FriedrichRober committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2087635 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Max Horn <max@quendi.de>
    @FriedrichRober @fingolfin
    FriedrichRober and fingolfin authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ee883b6 View commit details
    Browse the repository at this point in the history