Fix regression in IsomorphismPermGroupOrFailFpGroup that caused it to fail in situations that worked in GAP 4.12.2
#5709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in finding induced permutation representation of FpGroup, even if max parameter was increased in between. This resolves gap-system#5697
fingolfin
added
kind: bug
fingolfin
changed the title
IsomorphismPermGroupOrFailFpGroup that caused it to fail in situations used to handle fine in GAP 4.12.2 and earlierIsomorphismPermGroupOrFailFpGroup that caused it to fail in situations that worked in GAP 4.12.2
fingolfin
changed the title
IsomorphismPermGroupOrFailFpGroup that caused it to fail in situations that worked in GAP 4.12.2IsomorphismPermGroupOrFailFpGroup that caused it to fail in situations that worked in GAP 4.12.2
hulpke
approved these changes
May 6, 2024
There was a problem hiding this comment.
If you want to pull in fixes one-by-one that is fine by me. I will simply add new ones to the PR, as they arise, until it is fully merged.
(The reason for not keeping the commits separate in the first place is the approval process -- I don't want to have to keep track of approvals of 5 different PRs that all are minor fixes.)
fingolfin
added a commit
that referenced
this pull request
May 6, 2024
in finding induced permutation representation of FpGroup, even if max parameter was increased in between. This resolves #5697 Co-authored-by: Alexander Hulpke <hulpke@math.colostate.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5697
This has been extracted from PR #5698 by @hulpke mainly because it makes some maintenance tasks easier for me (managing the release notes, bisecting through commits to find sources of regressions etc.), and at the same time is supposed to not cause @hulpke any extra work (as we should be able to merge PR #5698 as-is after this one here).
I've also add a small test case.
Note that I've put this PR into the "bug" category, even though one can certainly argue that this is not fixing a bug, as the function
IsomorphismPermGroupOrFailFpGroupis allowed to returnfail. But it is fixing a regression compared to past GAP versions, and so to a user appears as "it used to work, then it didn't, now it does again", so category "bug" seems a bit more appropriate than "enhancement", and for the release notes we need to pick one of those.