Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildsys: detect 'check-manuals' exit code #5614

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

fingolfin
Copy link
Member

The 'tee' and subshell combo ate the exit code. Also get rid of the 'dev/log' subdirectory.

Resolves #1927

To test this, I am adding a commit causing issues, it should fail CI. If that works, I'll remove the commit and draft status of this PR.

The 'tee' and subshell combo ate the exit code. Also get rid of the
'dev/log' subdirectory.
@fingolfin fingolfin added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Jan 30, 2024
@fingolfin fingolfin marked this pull request as ready for review January 30, 2024 16:17
@fingolfin
Copy link
Member Author

Testing was successful, the error was detected and flagged by CI.

@fingolfin fingolfin merged commit 6873315 into gap-system:master Jan 30, 2024
22 checks passed
@fingolfin fingolfin deleted the mh/check-manuals branch January 30, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better detection of problems with building GAP manuals in CI
1 participant