Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update INSTALL.md #5598

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Update INSTALL.md #5598

merged 1 commit into from
Jan 22, 2024

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Jan 18, 2024

[skip ci]

@fingolfin fingolfin added topic: documentation Issues and PRs related to documentation release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Jan 18, 2024
@fingolfin fingolfin force-pushed the mh/INSTALLL.md branch 2 times, most recently from 526821e to a78182a Compare January 19, 2024 21:43
cursor back one character, and that `Ctrl-D` deletes single characters. So,
after entering the above commands, typing

Ctrl-P Ctrl-E Ctrl-B Ctrl-B Ctrl-B Ctrl-B Ctrl-D 2 Return
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this whole paragraph does not belong into INSTALL.md at all. It reads like something for power users.

@@ -519,13 +503,6 @@ which can reduce this limit even further.

We therefore recommend to always build and use GAP in 64-bit mode.

### Recompilation fails or the new binary crashes.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I won't claim this never happens, I think overall it is muuuuch rarer than it was with the build system used in GAP 4.8 and before, and as such it seems highly questionable to cover it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@fingolfin fingolfin merged commit b37f73e into master Jan 22, 2024
@fingolfin fingolfin deleted the mh/INSTALLL.md branch January 22, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: documentation Issues and PRs related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants