change the generic PermutationOp method
#5596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the action function to the points in the action domain, not to images computed by the action function. This is expected to yield a small improvement in the case of actions on elements of a f.p. group, where the lengths of the words tend to grow when one computes images. (The tests from `tst/testextra/grpperm.tst` are indeed sped up by the proposed change.)
ThomasBreuer
added
kind: enhancement
ChrisJefferson
approved these changes
Jan 19, 2024
fingolfin
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the action function to the points in the action domain, not to images computed by the action function.
This is expected to yield a small improvement in the case of actions on elements of a f.p. group, where the lengths of the words tend to grow when one computes images.
(The tests from
tst/testextra/grpperm.tstare indeed sped up by the proposed change.)The change was motivated by #5590.