WORKAROUND: Avoid problems in Fr/Kan packages #5479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulpke
added
release notes: not needed
The Kan package copied library code and thus uses undocumented entries of rewriting systems. Added workaround to avoid triggering an error in the test. fr package messes with the .tzrules without handling the pairs2check. Also commented out old code that is not used anymore but could be useful to have around for future debugging This resolves gap-system#5478
fingolfin
reviewed
Jul 28, 2023
fingolfin
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kan package copied library code and thus uses undocumented entries of rewriting systems. Added workaround to avoid triggering an error in the test.
fr package messes with the .tzrules without handling the pairs2check.
This resolves #5478