Fix printing of expressions including non-zero list levels #5453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, `([ x ]{[ 1 ]})[1]` was previously printed as
`([ x ]{[ 1 ]})[1]`, that is, the parentheses were missing.
|
The CI failure in |
| @@ -314,4 +314,30 @@ function ( x ) return ([ [ x ] ]{[ 1 ]}){[ 1 ]}{[ 1 ]}; end | |||
| # four extractions | |||
| gap> funcloop(x -> ([ [ x ] ]{[ 1 ]}{[ 1 ]}){[ 1 ]}{[ 1 ]}); | |||
| function ( x ) return ([ [ x ] ]{[ 1 ]}{[ 1 ]}){[ 1 ]}{[ 1 ]}; end | |||
|
|
|||
| # list access at level 0 after EXPR_ELMS_LIST | |||
| gap> funcloop(x -> ([ x ]{[ 1 ]})[1]); # EXPR_ELM_LIST | |||
There was a problem hiding this comment.
We probably also want to test the unbracketed case -- unless that is already somewhere else and I missed it?
There was a problem hiding this comment.
The unbracketed case [ x ]{[ 1 ]}[1] is an expression of type EXPR_ELM_LIST_LEV and thus uses a code path which I have not touched at all. The "other" case is the default case L[i] which I expect to be sufficiently covered. That's why I have not added further tests. But of course I could add further tests if you prefer.
ChrisJefferson
approved these changes
May 31, 2023
fingolfin
approved these changes
May 31, 2023
fingolfin
added
kind: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example,
([ x ]{[ 1 ]})[1]was previously printed as[ x ]{[ 1 ]}[1], that is, the parentheses were missing.This is a follow-up to #5116 which fixed this for nested sublist extractions only. This PR should now cover all possible cases.
See the description of the new helper function
ExprHasNonZeroListLevelfor details.Text for release notes
see title