Change handling of long command line options like --norepl so that repeating them will not toggle behaviour anymore
#5440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy with this change, as it does follow my experience with other software. If anyone wanted to be able to disable, we could add general support for |
fingolfin
added
release notes: use title
fingolfin
changed the title
--norepl so that repeating them will not toggle behaviour anymore
fingolfin
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4187 by only toggling short boolean options like
-Twhen repeated. Long options like--noreplare now idempotent. I have also edited the output ofgap -hto match this change, but I don't currently like the way it is worded (any suggestions?). I've glanced through the manual documentation to see if anything needs to be changed there, but the long command line options aren't yet documented (see #4197).