Fix Concatenation to reject Concatenation( [ 1 ] ) instead of returning 1, and in general do a better job at validating its inputs
#5427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zickgraf
force-pushed
the
Concatenation_checks
branch
from
4f7e8f4
to
1f6de1c
Compare
|
Can you add a testcase (perhaps in a new file in |
In particular, this lets the undefined expression `Concatenation( [ 1 ] )` throw an error instead of returning `1`.
zickgraf
force-pushed
the
Concatenation_checks
branch
from
1f6de1c
to
6220a99
Compare
Done. I don't think this is a bugfix in the strict sense, so I have added a file in |
fingolfin
approved these changes
Apr 4, 2023
fingolfin
changed the title
Concatenation to better validate its arguments and e.g. reject Concatenation( [ 1 ] ) with an error
fingolfin
added
kind: bug
fingolfin
changed the title
Concatenation to better validate its arguments and e.g. reject Concatenation( [ 1 ] ) with an errorConcatenation to reject Concatenation( [ 1 ] ) instead of returning 1, and in general do a better job at validating its inputs
fingolfin
removed
the
kind: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this lets the undefined expression
Concatenation( [ 1 ] )throw an error instead of returning1.The first commit fixes some inconsistencies I discovered while grepping for functions similar to
Concatenation.Text for release notes
none