Specify/unify the definition of CompanionMatrix
#5424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes gap-system#5423 - added an example to the documentation of `CompanionMatrix` for a polynomial (in `lib/upoly.gd`) - changed the definition of `CompanionMatrix` in `lib/matobj2.gd` from *row* convention to *column* convention, such that it fits to `CompanionMatrix` in `lib/upoly.gd`; changed the corresponding method (for `NewCompanionMatrix`) accordingly. - adjusted the tests
ThomasBreuer
added
kind: bug
ThomasBreuer
added a commit
to ThomasBreuer/cvec
that referenced
this pull request
Mar 27, 2023
according to the changes in gap-system/gap/pull/5424 (The negatives of the coefficients are in the last column, not in the last row.)
fingolfin
pushed a commit
to gap-packages/cvec
that referenced
this pull request
Mar 27, 2023
according to the changes in gap-system/gap/pull/5424 (The negatives of the coefficients are in the last column, not in the last row.)
fingolfin
approved these changes
Mar 27, 2023
fingolfin
changed the title
CompanionMatrix, adjusted the method for itCompanionMatrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5423
added an example to the documentation of
CompanionMatrixfor a polynomial (inlib/upoly.gd)changed the definition of
CompanionMatrixinlib/matobj2.gdfrom row convention to column convention, such that it fits toCompanionMatrixinlib/upoly.gd; changed the corresponding method (forNewCompanionMatrix) accordingly.adjusted the tests
(Now the method in the cvec package has to be adjusted as well.)