-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some contributor/developer guidelines #5399
Add some contributor/developer guidelines #5399
Conversation
ca4d9e1
to
30c1a53
Compare
c45ba21
to
102211d
Compare
102211d
to
a1a9f88
Compare
I am sure this can still be improved a lot, but it seems much better than what we have right now (i.e., nothing), so perhaps let's just merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than a number of minor typos which I've suggested fixes for.
Co-authored-by: James Mitchell <james-d-mitchell@users.noreply.github.com>
Thanks @james-d-mitchell all applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
- `testbugfix`: additional small test files that are created to verify | ||
specific bugfixes work as intended | ||
Run via `./gap tst/testbugfix.g` | ||
- `testinstall`: quick test suite that one can test frequently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Item is duplicate of first item
Some time ago I started work on some developer guidelines. I can't seem to find time to complete them, so I thought perhaps I should just post them anyway: better to have something incomplete than have nothing... And I also won't as easily forget about this.
Feedback, additions, improvements welcome.
This is meant to eventually address issue #3381 and perhaps others.
Resolves #2254
Resolves #2721