Support method dispatch based on tags (see the manual section "Tag Based Operations") #5344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBreuer
added
kind: enhancement
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@ChrisJefferson that's what I did and how I got the backtrace above. It unfortunately doesn't tell us much. I could easily break at it in gdb, I guess. But then what? |
This comment was marked as resolved.
This comment was marked as resolved.
fingolfin
reviewed
Feb 8, 2023
fingolfin
approved these changes
Feb 8, 2023
fingolfin
reviewed
Feb 8, 2023
lib/methsel.g
Outdated
| ## | ||
| #F NewKeyBasedOperation( <name>, <requirements> ) | ||
| #F DeclareKeyBasedOperation( <name>, <requirements> ) | ||
| #F InstallKeyBasedMethod( <oper>[, <key>], <meth> ) |
There was a problem hiding this comment.
I am slightly concerned that people will confuse this with KeyDependentOperation resp. confuse one with the other. So if someone has a good idea for an alternate name...
- added a new operation `DiagonalMatrix`, and added its documentation to the Reference Manual - added a new filter `IsRowVectorOrVectorObj`, analogous to `IsMatrixOrMatrixObj`, in order to simplify some method installations - moved the declarations of `DefaultVectorRepForBaseDomain` and `DefaultMatrixRepForBaseDomain` from `lib/matobj.gi` to `lib/matobj2.gd` - added a `CompatibleVectorFilter` method for `IsMatrix` object - added `NewZeroMatrix` and `NewIdentityMatrix` methods for `IsPlistRep` - added preliminary tests for `DiagonalMatrix` - removed some comment lines
as proposed in the discussion of gap-system#4398: - introduced `DeclareKeyBasedOperation`, `InstallKeyBasedMethod` (and `NewKeyBasedOperation`, in order to be able to write tests for them that can be run more than once in a session) - added a testfile - changed the code for `DiagonalMatrix` to use the setup given by the new functions (we could install methods depending on the representation but the main idea behind the change was that we do not have to do this) (Official documentation is still missing.)
ThomasBreuer
force-pushed
the
TB_DiagonalMat
branch
from
15d9d91
to
98a973a
Compare
|
I'm generally happy with this PR. If you were looking for an alternative name to "Key", then I've often seen this kind of thing called "Tag". |
wucas
approved these changes
Feb 9, 2023
|
O.k., I will replace "key" by "tag". |
ThomasBreuer
changed the title
DiagonalMatrix
ThomasBreuer
added
release notes: use title
ThomasBreuer
added a commit
to ThomasBreuer/gap
that referenced
this pull request
Mar 7, 2023
This is a follow-up of gap-system#5344, according to a comment in gap-system#4398.
This was referenced Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In calls to operations such as
DiagonalMatrix,CompanionMatrix, etc., one wants to specify the internal representation of the result via a filter (such asIsPlistMatrixRep) as the first argument. In order to be able to install individual methods depending on this filter, one does not really want to declare the operations as constructors because the result shall have exactly the given filter (and not perhaps something better), and also because one wants to be able to install a default method. (See the discussion of #4398 for details.)The changes proposed here provide an implementation (see commit 949cbc4) and documentation (see commit 9aaf40f) for this feature. Note that the operations in question are still GAP operations, the tag based mechanism is called only in the situation that the first argument is a filter.
The rest of the pull request applies the new mechanism to the operation
DiagonalMatrix:DiagonalMatrix, and added its documentation to the Reference ManualIsRowVectorOrVectorObj, analogous toIsMatrixOrMatrixObj, in order to simplify some method installationsDefaultVectorRepForBaseDomainandDefaultMatrixRepForBaseDomainfromlib/matobj.gitolib/matobj2.gdCompatibleVectorFiltermethod forIsMatrixobjectsNewZeroMatrixandNewIdentityMatrixmethods forIsPlistRepDiagonalMatrixAs soon as we agree on the details, the same changes can be applied to
PermutationMatrix,ReflectionMatrix,RandomMatrix, see issue #4367.Here are the perhaps controversial pieces of the changes:
DiagonalMatrix( list )behaves like the global functionDiagonalMat( list ), and thenDiagonalMatcould become deprecated.IsPlistRepmatrices to be supported w.r.t. functionality for matrix objects. Thus perhaps the "auxiliary"NewZeroMatrixandNewIdentityMatrixmethods forIsPlistRepand theCompatibleVectorFiltermethod forIsMatrixobjects are not what we want.