Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using GNU libtool for linking GAP and libgap #5306

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Stop using GNU libtool for linking GAP and libgap #5306

merged 1 commit into from
Jan 21, 2024

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Jan 6, 2023 •
edited
Loading

Resolves #4682
Resolves #5383

TODOs include at least:

  • Windows support
  • make install tweaks
  • testing on some *BSD variants
  • ...

@fingolfin fingolfin added do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) topic: build system release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Jan 6, 2023
@james-d-mitchell

This comment was marked as outdated.

Sign in to view
@fingolfin fingolfin changed the title WIP buildsys: stop using libool WIP buildsys: stop using libtool Jan 10, 2023
@fingolfin fingolfin force-pushed the mh/no-libtool branch 4 times, most recently from f2b2b00 to 31a9815 Compare January 12, 2023 15:16
@dimpase
Copy link
Member

dimpase commented Jan 13, 2023

just a note that there are packages which don't build on OpenBSD due to a libtool problem.

@fingolfin fingolfin force-pushed the mh/no-libtool branch 2 times, most recently from 029dc15 to 813e1d6 Compare January 18, 2023 22:44
@fingolfin fingolfin mentioned this pull request Jan 14, 2024
Closed
@fingolfin fingolfin force-pushed the mh/no-libtool branch 5 times, most recently from b7484a8 to 79ddf31 Compare January 16, 2024 09:27
@fingolfin fingolfin changed the title WIP buildsys: stop using libtool Stop using GNU libtool Jan 16, 2024
@fingolfin fingolfin marked this pull request as ready for review January 16, 2024 13:28
@fingolfin
Copy link
Member Author

This seems to be working now. What's not yet tested is anything other than Linux, macOS, Windows...

@fingolfin fingolfin removed the do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) label Jan 17, 2024
@dimpase
Copy link
Member

dimpase commented Jan 18, 2024

I'll test on OpenBSD and report.

dimpase
dimpase approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is good on OpenBSD 7.3. GAP builds, semigroups package builds, most tests in TestPackage("semigroups"); pass.

@fingolfin
Copy link
Member Author

Thanks @dimpase !

@fingolfin fingolfin added release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes and removed release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Jan 19, 2024
@fingolfin fingolfin changed the title Stop using GNU libtool Stop using GNU libtool for linking GAP and libgap Jan 19, 2024
@fingolfin
Copy link
Member Author

I think this should be mentioned in the release notes as it is quite relevant for downstream packagers

@fingolfin
Copy link
Member Author

(well ideally it is transparent for them, but I think it's good to make sure they are aware as it could cut down debugging time if anything breaks, and they might be able to get rid of some libtool specific adjustments etc.)

@fingolfin
Copy link
Member Author

Started a run of the package distro test suite at https://github.com/gap-system/PackageDistro/actions/runs/7589464817

@fingolfin
Copy link
Member Author

That package distro CI run failed due to the scripts there not being ready to deal with branches containing a slash... So I made gap-system/PackageDistro#877 and based on that started this test run which shows that all packages still pass with this PR here, yay!

https://github.com/gap-system/PackageDistro/actions/runs/7604428542/job/20707309882

@fingolfin fingolfin merged commit c4ebd31 into gap-system:master Jan 21, 2024
22 checks passed
@fingolfin fingolfin deleted the mh/no-libtool branch January 21, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

@dimpase dimpase dimpase approved these changes

Assignees
No one assigned
Labels
release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: build system
Projects
None yet
Milestone
No milestone
4 participants
@fingolfin @james-d-mitchell @dimpase @ChrisJefferson