Make SetUserPreferences obsolete #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuspf
added
the
gapsagedays2016
|
This looks OK to me (but obviously conflicts need fixing) |
|
To me to - discussed in #508 |
| local name, record; | ||
|
|
||
| Info( InfoWarning, 1, ""); | ||
| Info( InfoWarning, 1, Concatenation( [ |
There was a problem hiding this comment.
Shouldn't this use InfoObsolete (I know you just moved it, but this would be a logical change to apply next, wouldn't it?
It should be removed in 4.9
markuspf
force-pushed
the
obsolete-setuserpreference
branch
from
d72899f
to
b3034a0
Compare
|
Done. That was an oversight on my part, I didn't realise that there was a |
olexandr-konovalov
pushed a commit
that referenced
this pull request
Jan 28, 2016
Make SetUserPreferences obsolete
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be removed in 4.9