Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Orbits when called with a range as seeds #5057

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Fix Orbits when called with a range as seeds #5057

merged 1 commit into from
Sep 21, 2022

Conversation

fingolfin
Copy link
Member

Fixes #5056

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes backport-to-4.12 labels Sep 15, 2022
@fingolfin fingolfin mentioned this pull request Sep 15, 2022
Closed
@hulpke
Copy link
Contributor

hulpke commented Sep 16, 2022

Is there a test example?

@fingolfin
Copy link
Member Author

Yes but I forgot to git add it 😕. Will do once I am back at a computer

@fingolfin fingolfin mentioned this pull request Sep 17, 2022
Closed
@fingolfin
Copy link
Member Author

@hulpke example added

@fingolfin fingolfin changed the title Fix Orbits with a range as seeds Fix Orbits when called with a range as seeds Sep 20, 2022
@fingolfin fingolfin merged commit 7c390a9 into gap-system:master Sep 21, 2022
@fingolfin fingolfin deleted the mh/fix-Orbits branch September 21, 2022 12:10
@fingolfin fingolfin mentioned this pull request Oct 14, 2022
Merged
@fingolfin
Copy link
Member Author

Backported to stable-4.12 via commit 0a20c1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielrademacher danielrademacher danielrademacher approved these changes

@ChrisJefferson ChrisJefferson Awaiting requested review from ChrisJefferson

@hulpke hulpke Awaiting requested review from hulpke

@FriedrichRober FriedrichRober Awaiting requested review from FriedrichRober

Assignees
No one assigned
Labels
backport-to-4.12-DONE kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using ranges for seeds in Orbits
3 participants
@fingolfin @hulpke @danielrademacher