Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unexpected error in MinimalGeneratingSet for solvable non-pc groups #5041

Merged
merged 1 commit into from
Sep 9, 2022
+7 −2
Merged

Fix unexpected error in MinimalGeneratingSet for solvable non-pc groups #5041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/grp.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,16 +112,16 @@ InstallMethod(MinimalGeneratingSet,"test solvable and 2-generator noncyclic",
function(G)
local i;
if not HasIsSolvableGroup(G) and IsSolvableGroup(G) and
CanEasilyComputePcgs(G) then
CanEasilyComputePcgs(G) then
# discovered solvable -- redo
return MinimalGeneratingSet(G);
elif not IsSolvableGroup(G) then
if IsGroup(G) and (not IsCyclic(G)) and HasGeneratorsOfGroup(G)
and Length(GeneratorsOfGroup(G)) = 2 then
return GeneratorsOfGroup(G);
fi;
TryNextMethod();
fi;
TryNextMethod();
end);

#############################################################################
Expand Down
5 changes: 5 additions & 0 deletions tst/testbugfix/2022-09-09-MinimalGeneratingSet.tst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
gap> G:=Group((1,2),(2,3),(3,4));;
gap> H:=Image(IsomorphismFpGroup(G));;
gap> MinimalGeneratingSet(H);
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 4th choice method found for `MinimalGeneratingSet' on 1 arguments