-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: switch from ubuntu-18.04 to ubuntu-latest #5026
Conversation
Unfortunately the 32bit support (resp. availability of binaries) for several packages was removed in the latest Ubuntu version, which breaks our 32bit package tests. Of course we could just build the relevant libraries ourselves from scratch, or just not test those packages. Or just stop bothering to test packages in 32bit mode.. |
My personal temptation is to drop support -- I find it increasingly difficult to test 32-bit GAP (I've not got it to work in Ubuntu 22.04 on WSL for example, I think it's technically possible but I got weird linker messages). If we are going to withdraw support officially, I'd be tempted to add some kind of message when a 32-bit GAP is run, to say it's not supported anymore and might have bugs and asking for an email to gap-support for anyone using it, so we can find out if there is a large enough group of people who need 32-bits we are willing to go to the effort of testing it? |
1ba839a
to
260e87a
Compare
Fine by me. Open an issue for that, or just do it? |
Reason: ubuntu-18.04 will be removed in early 2023. Unfortunately this does not work with the package tests in 32bit build mode, so we leave this at ubuntu-18.04 for now.
260e87a
to
7e10dba
Compare
I've changed this now to retain the 32bit package tests using ubuntu-18.04 for now. Of course that means they'll break in early 2023. But it gives us the benefit for the other tests now, without debating on what to do with the 32bit tests, which we can discuss elsewhere. |
The former will be removed in early 2023
Resolves #5009