Avoid using InstallValue on non-plain objects #4919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InstallValue and friends are the only reason we need the somewhat dangerous kernel function `CLONE_OBJ`. It has known issues when used on e.g. families (which we already try to reject) and types. If we can eliminate all uses of it on component and positional objects, then we could potentially replace it by a simpler implementation (which would reject attempts to use it on such non-plain objects), which would also help avoid pitfalls in HPC-GAP.
fingolfin
added
topic: library
release notes: not needed
fingolfin
requested review from
ChrisJefferson,
olexandr-konovalov,
wucas and
FriedrichRober
ChrisJefferson
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstallValue and friends are the only reason we need the somewhat dangerous kernel function
CLONE_OBJ. It has known issues when used on e.g. families (which we already try to reject) and types (see #1637).If we can eliminate all uses of it on component and positional objects, then we could potentially replace it by a simpler implementation (which would reject attempts to use it on such non-plain objects), which would also help avoid pitfalls in HPC-GAP.