-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Earns
to always returns a list, as documented (and other improvements)
#4759
Conversation
83e406a
to
c444647
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix for Earns
is not complete. An empty list is now given instead of fail
(which is good), but the other case still returns an actual group, rather than a list containing one group (which is what the documentation suggests).
gap> Earns(PrimitiveGroup(8, 3));
Group([ (1,7)(2,8)(3,5)(4,6), (1,3)(2,4)(5,7)(6,8), (1,2)(3,4)(5,6)(7,8) ])
Thank you @wilfwilson -- did not realize that was part of the issue. Will fix. |
method for `RepresentativeAction` has been defined (i.e. pc and perm) and store data/no need for short words in `NormalSubgroups`
and subsequent changes. This fixes gap-system#4744
Special case more applicable. Remove duplicate rules, improve borel action. Also clean up broad code duplication.
Utility functions/data structure for finding rewriting rule that would apply to word at give position. This is faster (and cleaner) than the caching/sorting kludges used before. If code manipulates the `tzrules` entry (as the `fr` package does), the functionality is disabled.
subsequent manual example
Earns
to always returns a list, as documented
Earns
to always returns a list, as documentedEarns
to always returns a list, as documented (and other improvements)
Recent improvements:
Earns
to agree with its definition.SubgroupConditionAbove
works for arbitrary groups, not just permutation groupsLowLayerSubgroups
uses orbit in favor of pairwise conjugacy, if this is a plausible approach.Text for release notes
As promised in the manual, Earns now always returns a list.