-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change syntax errors/warnings to use FILE:LINE format #469
Conversation
+1 |
@@ -329,8 +329,12 @@ InstallGlobalFunction("Test", function(arg) | |||
if d[1] <> '-' then | |||
d := Concatenation("+", d); | |||
fi; | |||
Print("########> Time diff in ", | |||
fnam,", line ",line,":\n"); | |||
Print("########> Time diff in ") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No semicolon in this line - that's what causing Travis tests to fail. Please fix it and I suggest to merge it - no objections expressed during three weeks.
d80d668
to
17ca2a9
Compare
I'd merge this, but tests are failing :/ |
@markuspf someone just to check systematically and update error messages included in tests, eg
should be
|
On Thu, Feb 18, 2016 at 07:19:46AM -0800, Alexander Konovalov wrote:
The operative words being "someone" and "just". |
I just saw this message, and wanted to see what errors there are, and look into resolving them. But I see this has now been merged anyway? I am confused?! |
This changes syntax errors and warnings to print slightly differently. Before:
After:
The primary reason I'd like to see that is selfish: Such strings are recognized by my terminal, and I can Cmd-click them to open an editor for that file, at the correct line.
This format also matches the output of gcc and clang when it comes to errors:
I realize that might be a somewhat bizarre reason, but I thought I could at least try to convince you this is useful ;-).
Of course, there is a the potential drawback that end users may not understand the new output.