buildsys: restrict vpath to src directory #4679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
force-pushed
the
mh/buildsys-restrict-vpath
branch
from
9de223b
to
67bfa4c
Compare
The `vpath` directives are what makes out-of-tree builds possible. With
them, if a source file is not present in `${builddir}`, then GNU make
automatically looks for it in `${srcdir}`.
For files in `src`, this is generally what we want. But for generated
files in `build`, we do *not* want that. As a result, it could happen
that instead of `${builddir}/build/gap_version.c` we would access
`${srcdir}/build/gap_version.c`, and so on.
This patch fixes this by restricting the `vpath` directives to files
inside `src` subdirectory.
fingolfin
force-pushed
the
mh/buildsys-restrict-vpath
branch
from
c331421
to
4c58208
Compare
fingolfin
added
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a short summary of this PR and its purpose here. E.g., does it add a new feature, and which? Does it fix a bug, and which? If there is an associated issue, please list it here.
Text for release notes
We track noteworthy changes as entries in the
CHANGES.mdfile in the root directory of this repository. To help us decide whether and how to describe your PR, please do one of the following:CHANGES.md, and write "see title" here (or if you have the required permissions, add the labelrelease notes: use titleto this PR and remove this section)Further details
If necessary, provide further details down here.