Fix RootSystem to use the correct field for determining eigenvectors
#4665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was assumed that the DefaultField of the minimal polynomial ist the field to factor it over. In some cases, i.e. x^2+1 for some Lie Algebra over CC (=Field(E(4))) this differs and thus makes RootSystem fail. Add test to `testbugfix`.
fingolfin
added
kind: bug
fingolfin
changed the title
RootSystem use the correct field for determining eigenvectors
fingolfin
added
release notes: use title
fingolfin
changed the title
RootSystem use the correct field for determining eigenvectorsRootSystem to use the correct field for determining eigenvectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was assumed that the DefaultField of the minimal polynomial is the field to factor it over. In some cases, i.e. x^2+1 for some Lie Algebra over CC (=Field(E(4))) this differs and thus makes RootSystem fail.
Now, it uses the field of the lie algebra.
Closes #4661
Text for release notes
see title