Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Accessing list entries and record components of expressions #462

Merged
merged 1 commit into from
Feb 19, 2016

Conversation

ChrisJefferson
Copy link
Contributor

Implementing the original requirements from #457.

@olexandr-konovalov olexandr-konovalov added the gapdays2015-fall Issues and PRs that arose at https://www.gapdays.de/gapdays2015-fall label Jan 15, 2016
@fingolfin fingolfin changed the title [WIP] modifiers trial [WIP] Accessing list entries and record components of expressions Jan 15, 2016
@fingolfin
Copy link
Member

So, what is the status of this? Any particular known issues? Anything missing? Apart from documentation for this new feature.

If not, I am all for merging it -- though I am a bit scared of "forgetting" to document this new feature. And announcing it to people once 4.9 is released. Do we have a good scheme for taking care of that already? If not, we should think about setting one up. Perhaps @alex-konovalov can comment?

@olexandr-konovalov
Copy link
Member

@fingolfin: I've created a new Wiki page for the overview of changes between GAP 4.8. and 4.9: https://github.com/gap-system/gap/wiki/Changes-between-GAP-4.8-and-GAP-4.9. On that page we should collect important changes which should be included in the release overview. If you don't have time to polish formulations, or even to write several sentences, just put a number of an issue or a pull request under one of the appropriate headings on that page, so this information will be remembered and you or someone else may improve the description later.

@markuspf
Copy link
Member

I think we should add documentation and merge this. I'd hit the merge button right now, but I do agree with Max that we'd end up with yet another undocumented feature.

@ChrisJefferson
Copy link
Contributor Author

I can't decide where to put documentation for that.. I mean we never really clearly list anywhere we can / can't index the results of function calls, etc.

We should be sure to mention it in release notes, for existing GAP users.

markuspf added a commit that referenced this pull request Feb 19, 2016
Accessing list entries and record components of expressions
@markuspf markuspf merged commit 23f2ffb into gap-system:master Feb 19, 2016
@frankluebeck
Copy link
Member

I would say that an explicit documentation is not needed in this case. It is more that this nice pull request makes things work which some people from time to time expected to work anyway.

Maybe an entry in a CHANGES file which gives a few examples of code that now works would be appropriate?

@ChrisJefferson ChrisJefferson deleted the modifiers branch April 15, 2016 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gapdays2015-fall Issues and PRs that arose at https://www.gapdays.de/gapdays2015-fall
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants