Speed up PositionSublist by using Position to search for first entry
#4599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entry, instead of linear search in the library. This is much faster when there is little self-overlap. Ultimately, this should become a kernel function.
hulpke
added
kind: enhancement
fingolfin
approved these changes
Jul 6, 2021
There was a problem hiding this comment.
Nice!
I took the liberty of pushing another commit to this PR which refactors it a bit, to reduce diffs (when hiding whitespace diffs) to the previous version of the code (and some negligible performance gains -- like, for loops over ranges are a bit faster than while loops).
wilfwilson
approved these changes
Jul 6, 2021
fingolfin
changed the title
PositionSublist uses Position to search for first entryPositionSublist by using Position to search for first entry
fingolfin
added
topic: performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of linear search in the library. This is much faster when there is little self-overlap.
This is used in some of the routines working with presentations and gives a significant speedup.
Ultimately, this should become a kernel function.