Improve property deduction for simple groups #4546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: enhancement
wilfwilson
changed the title
wilfwilson
reviewed
Jun 7, 2021
|
Thanks! I don't see how to add a new file to the "suggested changes" in the review. But the silly gap/tst/teststandard/ctblmono.tst Line 29 in 682f8a4 can be removed in this commit too (after rebasing it off a more recent development version). A simple: should work now, thanks to this commit 🎉 |
- change various constructors for simple groups to also indicate the constructed groups are nonabelian - add some more automatic implications: nonabelian simple groups are also non-nilpotent and non-solvable Now `IsSolvableGroup(SuzukiGroup(2^9));` returns instantly, as GAP already knows the answer.
fingolfin
force-pushed
the
mh/SetIsSimpleGroup
branch
from
48e626b
to
b295ed3
Compare
wilfwilson
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constructed groups are nonabelian
also non-nilpotent and non-solvable
Now
IsSolvableGroup(SuzukiGroup(2^9));returns instantly, as GAPalready knows the answer.
CC @jackschmidt