Add GAP_IsMatrix
#4531
Merged
Add GAP_IsMatrix
#4531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and added/corrected some comments concerning functions about `GAP_IsMatrix*`
fingolfin
reviewed
Jun 4, 2021
src/libgap-api.c
Outdated
| // Returns 1 if <obj> is a GAP matrix, 0 if not. | ||
| int GAP_IsMatrix(Obj obj) | ||
| { | ||
| return obj && DoFilter(IsMatrixFilt, obj) == True; |
There was a problem hiding this comment.
IsMatrix is not a plain filter, but rather an and-filter, so calling DoFilter is wrong and the cause for the crash in the CI tests.
Suggested change
| return obj && DoFilter(IsMatrixFilt, obj) == True; | |
| return obj && CALL_1ARGS(IsMatrixFilt, obj) == True; |
I suggest we change GAP_IsMatrixOrMatrixObj and GAP_IsMatrixObj similarly -- while DoFilter works for them right now, it's a bit risky, as any change to their definition would accidentally break this code.
... and make `GAP_IsMatrixOrMatrixObj`, `GAP_IsMatrixObj` future proof: directly calling `DoFilter` is risky and will break as soon as the "filter" we are passing in is not a true filter, but e.g. an and-filter (such as `IsMatrix`)
fingolfin
approved these changes
Jun 5, 2021
fingolfin
added
the
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and added/corrected some comments concerning functions about
GAP_IsMatrix*